Add dperecation warnings and fix tests in AssociationCollection

cakephp · Nov 16, 2017 · 6e9db33 · 6e9db33
1 parent df72de9
commit 6e9db33
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/ORM/AssociationCollection.php b/src/ORM/AssociationCollection.php
@@ -160,6 +160,10 @@ public function keys()
      */
     public function type($class)
     {
+        deprecationWarning(
+            'AssociationCollection::type() is deprecated. ' .
+            'Use getByType() instead.'
+        );
         return $this->getByType($class);
     }
 

diff --git a/tests/TestCase/ORM/AssociationCollectionTest.php b/tests/TestCase/ORM/AssociationCollectionTest.php
@@ -159,7 +159,7 @@ public function testGetByProperty()
         $belongsTo = new BelongsTo('Users', [
             'sourceTable' => $table
         ]);
-        $this->assertEquals('user', $belongsTo->property());
+        $this->assertEquals('user', $belongsTo->getProperty());
         $this->associations->add('Users', $belongsTo);
         $this->assertNull($this->associations->get('user'));