Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make CakeRoute::persistParams() more tolerant
Subclasses and instances may not always define persist options. CakeRoute should be accepting of these differences. Fixes #3957
- Loading branch information
Showing
2 changed files
with
37 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8209a29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change means
'persist' => true
won't work anymore?http://book.cakephp.org/2.0/en/development/routing.html#redirect-routing
8209a29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it should continue to work as it did before. The existing test cases continue to pass. RedirectRoute implements persist differently from what I remember.
8209a29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I confused the two, thanks.