Skip to content

Commit

Permalink
Renaming method to better express its purpose
Browse files Browse the repository at this point in the history
  • Loading branch information
@lorenzo
lorenzo committed Oct 18, 2013
1 parent b9d209e commit 84b9f4e
Showing 1 changed file with 20 additions and 20 deletions.
40 changes: 20 additions & 20 deletions Cake/Test/TestCase/ORM/QueryTest.php
View file
Expand Up @@ -92,7 +92,7 @@ public function tearDown() {
*
* @return void
*/
protected function _createTables() {
protected function _configureTables() {
Table::config('authors', ['connection' => $this->connection]);
Table::config('articles', ['connection' => $this->connection]);
Table::config('publications', ['connection' => $this->connection]);
Expand Down Expand Up @@ -259,7 +259,7 @@ public function testContainToFieldsDefault() {
* @return void
**/
public function testContainResultFetchingOneLevelNoHydration() {
$this->_createTables();
$this->_configureTables();

$table = Table::build('article', ['table' => 'articles']);
Table::build('author', ['connection' => $this->connection]);
Expand Down Expand Up @@ -328,7 +328,7 @@ public function strategiesProvider() {
* @return void
**/
public function testHasManyEagerLoadingNoHydration($strategy) {
$this->_createTables();
$this->_configureTables();

$table = Table::build('author', ['connection' => $this->connection]);
Table::build('article', ['connection' => $this->connection]);
Expand Down Expand Up @@ -405,7 +405,7 @@ public function testHasManyEagerLoadingNoHydration($strategy) {
* @return void
**/
public function testHasManyEagerLoadingFieldsAndOrderNoHydration($strategy) {
$this->_createTables();
$this->_configureTables();

$table = Table::build('author', ['connection' => $this->connection]);
Table::build('article', ['connection' => $this->connection]);
Expand Down Expand Up @@ -456,7 +456,7 @@ public function testHasManyEagerLoadingFieldsAndOrderNoHydration($strategy) {
* @return void
**/
public function testHasManyEagerLoadingDeepNoHydration($strategy) {
$this->_createTables();
$this->_configureTables();

$table = Table::build('author', ['connection' => $this->connection]);
$article = Table::build('article', ['connection' => $this->connection]);
Expand Down Expand Up @@ -529,7 +529,7 @@ public function testHasManyEagerLoadingDeepNoHydration($strategy) {
* @return void
**/
public function testHasManyEagerLoadingFromSecondaryTable($strategy) {
$this->_createTables();
$this->_configureTables();

$author = Table::build('author', ['connection' => $this->connection]);
$article = Table::build('article', ['connection' => $this->connection]);
Expand Down Expand Up @@ -633,7 +633,7 @@ public function testHasManyEagerLoadingFromSecondaryTable($strategy) {
* @return void
**/
public function testBelongsToManyEagerLoadingNoHydration($strategy) {
$this->_createTables();
$this->_configureTables();

$table = Table::build('Article', ['connection' => $this->connection]);
Table::build('Tag', ['connection' => $this->connection]);
Expand Down Expand Up @@ -738,7 +738,7 @@ public function testBelongsToManyEagerLoadingNoHydration($strategy) {
* @return void
*/
public function testFilteringByHasManyNoHydration() {
$this->_createTables();
$this->_configureTables();

$query = new Query($this->connection, $this->table);
$table = Table::build('author', ['connection' => $this->connection]);
Expand Down Expand Up @@ -777,7 +777,7 @@ public function testFilteringByHasManyNoHydration() {
* @return void
**/
public function testFilteringByBelongsToManyNoHydration() {
$this->_createTables();
$this->_configureTables();

$query = new Query($this->connection, $this->table);
$table = Table::build('Article', ['connection' => $this->connection]);
Expand Down Expand Up @@ -1053,7 +1053,7 @@ function($k, $v, $mr) {
* @return void
*/
public function testFirstDirtyQuery() {
$this->_createTables();
$this->_configureTables();
$table = Table::build('article', ['table' => 'articles']);
$query = new Query($this->connection, $table);
$result = $query->select(['id'])->hydrate(false)->first();
Expand All @@ -1069,7 +1069,7 @@ public function testFirstDirtyQuery() {
* @return void
*/
public function testFirstCleanQuery() {
$this->_createTables();
$this->_configureTables();
$table = Table::build('article', ['table' => 'articles']);
$query = new Query($this->connection, $table);
$query->select(['id'])->toArray();
Expand All @@ -1085,7 +1085,7 @@ public function testFirstCleanQuery() {
* @return void
*/
public function testFirstSameResult() {
$this->_createTables();
$this->_configureTables();
$table = Table::build('article', ['table' => 'articles']);
$query = new Query($this->connection, $table);
$query->select(['id'])->toArray();
Expand All @@ -1102,7 +1102,7 @@ public function testFirstSameResult() {
* @return void
*/
public function testHydrateSimple() {
$this->_createTables();
$this->_configureTables();
$table = Table::build('article', ['table' => 'articles']);
$query = new Query($this->connection, $table);
$results = $query->select()->execute()->toArray();
Expand All @@ -1126,7 +1126,7 @@ public function testHydrateSimple() {
* @return void
*/
public function testHydrateWithHasMany() {
$this->_createTables();
$this->_configureTables();

$table = Table::build('author', ['connection' => $this->connection]);
Table::build('article', ['connection' => $this->connection]);
Expand Down Expand Up @@ -1169,7 +1169,7 @@ public function testHydrateWithHasMany() {
* @return void
*/
public function testHydrateBelongsToMany() {
$this->_createTables();
$this->_configureTables();

$table = Table::build('Article', ['connection' => $this->connection]);
Table::build('Tag', ['connection' => $this->connection]);
Expand Down Expand Up @@ -1212,7 +1212,7 @@ public function testHydrateBelongsToMany() {
* @return void
*/
public function testHydrateBelongsTo() {
$this->_createTables();
$this->_configureTables();

$table = Table::build('article', ['table' => 'articles']);
Table::build('author', ['connection' => $this->connection]);
Expand All @@ -1237,7 +1237,7 @@ public function testHydrateBelongsTo() {
* @return void
*/
public function testHydrateDeep() {
$this->_createTables();
$this->_configureTables();

$table = Table::build('author', ['connection' => $this->connection]);
$article = Table::build('article', ['connection' => $this->connection]);
Expand Down Expand Up @@ -1266,7 +1266,7 @@ public function testHydrateDeep() {
* @return void
*/
public function testHydrateCustomObject() {
$this->_createTables();
$this->_configureTables();
$class = $this->getMockClass('\Cake\ORM\Entity', ['fakeMethod']);
$table = Table::build('article', [
'table' => 'articles',
Expand Down Expand Up @@ -1295,7 +1295,7 @@ public function testHydrateCustomObject() {
* @return void
*/
public function testHydrateWithHasManyCustomEntity() {
$this->_createTables();
$this->_configureTables();

$authorEntity = $this->getMockClass('\Cake\ORM\Entity', ['foo']);
$articleEntity = $this->getMockClass('\Cake\ORM\Entity', ['foo']);
Expand Down Expand Up @@ -1339,7 +1339,7 @@ public function testHydrateWithHasManyCustomEntity() {
* @return void
*/
public function testHydrateBelongsToCustomEntity() {
$this->_createTables();
$this->_configureTables();

$authorEntity = $this->getMockClass('\Cake\ORM\Entity', ['foo']);
$table = Table::build('article', ['table' => 'articles']);
Expand Down

0 comments on commit 84b9f4e

Please sign in to comment.