Skip to content

Commit

Permalink
Renaming variable
Browse files Browse the repository at this point in the history
  • Loading branch information
lorenzo committed Aug 21, 2013
1 parent 09bde3c commit acc00a7
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions lib/Cake/ORM/Table.php
Expand Up @@ -545,27 +545,27 @@ public function findAll(Query $query, array $options = []) {
* @return \Cake\ORM\Query
*/
public function findList(Query $query, array $options = []) {
$mapper = function($key, $row, $mr) use (&$columns) {
$mapper = function($key, $row, $mapReduce) use (&$columns) {
if (empty($columns)) {
$columns = array_slice(array_keys($row), 0, 3);
}

list($rowKey, $rowVal) = $columns;
if (!isset($columns[2])) {
$mr->emit($row[$rowVal], $row[$rowKey]);
$mapReduce->emit($row[$rowVal], $row[$rowKey]);
return;
}

$key = $row[$columns[2]];
$mr->emitIntermediate($key, [$row[$rowKey] => $row[$rowVal]]);
$mapReduce->emitIntermediate($key, [$row[$rowKey] => $row[$rowVal]]);
};

$reducer = function($key, $values, $mr) {
$reducer = function($key, $values, $mapReduce) {
$result = [];
foreach ($values as $value) {
$result += $value;
}
$mr->emit($result, $key);
$mapReduce->emit($result, $key);
};

return $query->mapReduce($mapper, $reducer);
Expand All @@ -584,16 +584,16 @@ public function findList(Query $query, array $options = []) {
*/
public function findThreaded(Query $query, array $options = []) {
$parents = [];
$mapper = function($key, $row, $mr) use (&$parents) {
$mapper = function($key, $row, $mapReduce) use (&$parents) {
$parents[$row['id']] =& $row;
$mr->emitIntermediate($row['parent_id'], $row['id']);
$mapReduce->emitIntermediate($row['parent_id'], $row['id']);
};

$reducer = function($key, $values, $mr) use (&$parents) {
$reducer = function($key, $values, $mapReduce) use (&$parents) {
if (empty($key) || !isset($parents[$key])) {
foreach ($values as $id) {
$parents[$id] = new \ArrayObject($parents[$id]);
$mr->emit($parents[$id]);
$mapReduce->emit($parents[$id]);
}
return;
}
Expand All @@ -602,8 +602,8 @@ public function findThreaded(Query $query, array $options = []) {
}
};

$formatter = function($key, $row, $mr) {
$mr->emit($row->getArrayCopy());
$formatter = function($key, $row, $mapReduce) {
$mapReduce->emit($row->getArrayCopy());
};
return $query->mapReduce($mapper, $reducer)->mapReduce($formatter);
}
Expand Down

0 comments on commit acc00a7

Please sign in to comment.