Skip to content

Commit

Permalink
Merge pull request #2181 from bcrowe/hotfix-classname
Browse files Browse the repository at this point in the history
Add space between classname(s)
  • Loading branch information
markstory committed Oct 23, 2013
2 parents bd4aff1 + a943ea5 commit b4a0182
Show file tree
Hide file tree
Showing 17 changed files with 30 additions and 30 deletions.
8 changes: 4 additions & 4 deletions lib/Cake/Console/Command/Task/TestTask.php
Expand Up @@ -295,7 +295,7 @@ public function buildTestSubject($type, $class) {
*
* @param string $type The Type of object you are generating tests for eg. controller
* @param string $class the Classname of the class the test is being generated for.
* @return string Real classname
* @return string Real class name
*/
public function getRealClassName($type, $class) {
if (strtolower($type) === 'model' || empty($this->classTypes[$type])) {
Expand Down Expand Up @@ -430,7 +430,7 @@ protected function _processController($subject) {
}

/**
* Add classname to the fixture list.
* Add class name to the fixture list.
* Sets the app. or plugin.plugin_name. prefix.
*
* @param string $name Name of the Model class that a fixture might be required for.
Expand Down Expand Up @@ -476,7 +476,7 @@ public function hasMockClass($type) {
}

/**
* Generate a constructor code snippet for the type and classname
* Generate a constructor code snippet for the type and class name
*
* @param string $type The Type of object you are generating tests for eg. controller
* @param string $fullClassName The Classname of the class the test is being generated for.
Expand Down Expand Up @@ -504,7 +504,7 @@ public function generateConstructor($type, $fullClassName, $plugin) {
}

/**
* Generate the uses() calls for a type & classname
* Generate the uses() calls for a type & class name
*
* @param string $type The Type of object you are generating tests for eg. controller
* @param string $realType The package name for the class.
Expand Down
6 changes: 3 additions & 3 deletions lib/Cake/Controller/Controller.php
Expand Up @@ -86,7 +86,7 @@ class Controller extends Object implements CakeEventListener {

/**
* An array containing the names of helpers this controller uses. The array elements should
* not contain the "Helper" part of the classname.
* not contain the "Helper" part of the class name.
*
* Example: `public $helpers = array('Html', 'Js', 'Time', 'Ajax');`
*
Expand Down Expand Up @@ -114,7 +114,7 @@ class Controller extends Object implements CakeEventListener {
public $response;

/**
* The classname to use for creating the response object.
* The class name to use for creating the response object.
*
* @var string
*/
Expand Down Expand Up @@ -182,7 +182,7 @@ class Controller extends Object implements CakeEventListener {

/**
* Array containing the names of components this controller uses. Component names
* should not contain the "Component" portion of the classname.
* should not contain the "Component" portion of the class name.
*
* Example: `public $components = array('Session', 'RequestHandler', 'Acl');`
*
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/Log/CakeLog.php
Expand Up @@ -192,7 +192,7 @@ public static function config($key, $config) {
throw new CakeLogException(__d('cake_dev', 'Invalid key name'));
}
if (empty($config['engine'])) {
throw new CakeLogException(__d('cake_dev', 'Missing logger classname'));
throw new CakeLogException(__d('cake_dev', 'Missing logger class name'));
}
if (empty(self::$_Collection)) {
self::_init();
Expand Down
8 changes: 4 additions & 4 deletions lib/Cake/Model/Model.php
Expand Up @@ -294,7 +294,7 @@ class Model extends Object implements CakeEventListener {
*
* ### Possible keys in association
*
* - `className`: the classname of the model being associated to the current model.
* - `className`: the class name of the model being associated to the current model.
* If you're defining a 'Profile belongsTo User' relationship, the className key should equal 'User.'
* - `foreignKey`: the name of the foreign key found in the current model. This is
* especially handy if you need to define multiple belongsTo relationships. The default
Expand Down Expand Up @@ -341,7 +341,7 @@ class Model extends Object implements CakeEventListener {
*
* ### Possible keys in association
*
* - `className`: the classname of the model being associated to the current model.
* - `className`: the class name of the model being associated to the current model.
* If you're defining a 'User hasOne Profile' relationship, the className key should equal 'Profile.'
* - `foreignKey`: the name of the foreign key found in the other model. This is
* especially handy if you need to define multiple hasOne relationships.
Expand Down Expand Up @@ -384,7 +384,7 @@ class Model extends Object implements CakeEventListener {
*
* ### Possible keys in association
*
* - `className`: the classname of the model being associated to the current model.
* - `className`: the class name of the model being associated to the current model.
* If you're defining a 'User hasMany Comment' relationship, the className key should equal 'Comment.'
* - `foreignKey`: the name of the foreign key found in the other model. This is
* especially handy if you need to define multiple hasMany relationships. The default
Expand Down Expand Up @@ -435,7 +435,7 @@ class Model extends Object implements CakeEventListener {
*
* ### Possible keys in association
*
* - `className`: the classname of the model being associated to the current model.
* - `className`: the class name of the model being associated to the current model.
* If you're defining a 'Recipe HABTM Tag' relationship, the className key should equal 'Tag.'
* - `joinTable`: The name of the join table used in this association (if the
* current table doesn't adhere to the naming convention for HABTM join tables).
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/Network/Email/CakeEmail.php
Expand Up @@ -326,7 +326,7 @@ class CakeEmail {
protected $_emailPattern = null;

/**
* The classname used for email configuration.
* The class name used for email configuration.
*
* @var string
*/
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/Network/Http/HttpSocket.php
Expand Up @@ -78,7 +78,7 @@ class HttpSocket extends CakeSocket {
public $response = null;

/**
* Response classname
* Response class name
*
* @var string
*/
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/Routing/Dispatcher.php
Expand Up @@ -238,7 +238,7 @@ protected function _getController($request, $response) {
}

/**
* Load controller and return controller classname
* Load controller and return controller class name
*
* @param CakeRequest $request
* @return string|boolean Name of controller class name
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/Test/Case/Console/Command/SchemaShellTest.php
Expand Up @@ -587,7 +587,7 @@ public function testName() {

/**
* test that passing name and file creates the passed filename with the
* passed classname
* passed class name
*
* @return void
*/
Expand Down
6 changes: 3 additions & 3 deletions lib/Cake/Test/Case/Console/Command/Task/TestTaskTest.php
Expand Up @@ -324,7 +324,7 @@ public function testRegistryClearWhenBuildingTestObjects() {
}

/**
* test that getClassName returns the user choice as a classname.
* test that getClassName returns the user choice as a class name.
*
* @return void
*/
Expand Down Expand Up @@ -359,7 +359,7 @@ public function testGetUserFixtures() {
}

/**
* test that resolving classnames works
* test that resolving class names works
*
* @return void
*/
Expand Down Expand Up @@ -394,7 +394,7 @@ public function testGetRealClassname() {

/**
* test baking files. The conditionally run tests are known to fail in PHP4
* as PHP4 classnames are all lower case, breaking the plugin path inflection.
* as PHP4 class names are all lower case, breaking the plugin path inflection.
*
* @return void
*/
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/Test/Case/Network/Email/CakeEmailTest.php
Expand Up @@ -27,7 +27,7 @@
class TestCakeEmail extends CakeEmail {

/**
* Config classname.
* Config class name.
*
* Use a the testing config class in this file.
*
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/TestSuite/CakeTestSuiteCommand.php
Expand Up @@ -55,7 +55,7 @@ public function __construct($loader, $params = array()) {
}

/**
* Ugly hack to get around PHPUnit having a hard coded classname for the Runner. :(
* Ugly hack to get around PHPUnit having a hard coded class name for the Runner. :(
*
* @param array $argv
* @param boolean $exit
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/TestSuite/Coverage/HtmlCoverageReport.php
Expand Up @@ -105,7 +105,7 @@ public function generateDiff($filename, $fileLines, $coverageData) {
}

/**
* Guess the classname the test was for based on the test case filename.
* Guess the class name the test was for based on the test case filename.
*
* @param ReflectionClass $testReflection.
* @return string Possible test subject name.
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/Utility/Debugger.php
Expand Up @@ -805,7 +805,7 @@ public function outputError($data) {
}

/**
* Get the type of the given variable. Will return the classname
* Get the type of the given variable. Will return the class name
* for objects.
*
* @param mixed $var The variable to get the type of
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/View/Helper.php
Expand Up @@ -780,7 +780,7 @@ protected function _initInputField($field, $options = array()) {
* Adds the given class to the element options
*
* @param array $options Array options/attributes to add a class to
* @param string $class The classname being added.
* @param string $class The class name being added.
* @param string $key the key to use for class.
* @return array Array of options with $key set.
*/
Expand Down
6 changes: 3 additions & 3 deletions lib/Cake/View/Helper/FormHelper.php
Expand Up @@ -650,7 +650,7 @@ public function isFieldError($field) {
* - `escape` boolean - Whether or not to html escape the contents of the error.
* - `wrap` mixed - Whether or not the error message should be wrapped in a div. If a
* string, will be used as the HTML tag to use.
* - `class` string - The classname for the error message
* - `class` string - The class name for the error message
*
* @param string $field A field name, like "Modelname.fieldname"
* @param string|array $text Error message as string or array of messages.
Expand Down Expand Up @@ -836,7 +836,7 @@ public function label($fieldName = null, $text = null, $options = array()) {
* @param array $blacklist A simple array of fields to not create inputs for.
* @param array $options Options array. Valid keys are:
* - `fieldset` Set to false to disable the fieldset. If a string is supplied it will be used as
* the classname for the fieldset element.
* the class name for the fieldset element.
* - `legend` Set to false to disable the legend for the generated input set. Or supply a string
* to customize the legend text.
* @return string Completed form inputs.
Expand Down Expand Up @@ -1913,7 +1913,7 @@ public function submit($caption = null, $options = array()) {
* that string is displayed as the empty element.
* - `escape` - If true contents of options will be HTML entity encoded. Defaults to true.
* - `value` The selected value of the input.
* - `class` - When using multiple = checkbox the classname to apply to the divs. Defaults to 'checkbox'.
* - `class` - When using multiple = checkbox the class name to apply to the divs. Defaults to 'checkbox'.
* - `disabled` - Control the disabled attribute. When creating a select box, set to true to disable the
* select box. When creating checkboxes, `true` will disable all checkboxes. You can also set disabled
* to a list of values you want to disable when creating checkboxes.
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/View/Helper/TimeHelper.php
Expand Up @@ -351,7 +351,7 @@ public function toRSS($dateString, $timezone = null) {
* - `element` - The element to wrap the formatted time in.
* Has a few additional options:
* - `tag` - The tag to use, defaults to 'span'.
* - `class` - The classname to use, defaults to `time-ago-in-words`.
* - `class` - The class name to use, defaults to `time-ago-in-words`.
* - `title` - Defaults to the $dateTime input.
*
* @param integer|string|DateTime $dateTime UNIX timestamp, strtotime() valid string or DateTime object
Expand Down
4 changes: 2 additions & 2 deletions lib/Cake/basics.php
Expand Up @@ -205,15 +205,15 @@ function h($text, $double = true, $charset = null) {
if (!function_exists('pluginSplit')) {

/**
* Splits a dot syntax plugin name into its plugin and classname.
* Splits a dot syntax plugin name into its plugin and class name.
* If $name does not have a dot, then index 0 will be null.
*
* Commonly used like `list($plugin, $name) = pluginSplit($name);`
*
* @param string $name The name you want to plugin split.
* @param boolean $dotAppend Set to true if you want the plugin to have a '.' appended to it.
* @param string $plugin Optional default plugin to use if no plugin is found. Defaults to null.
* @return array Array with 2 indexes. 0 => plugin name, 1 => classname
* @return array Array with 2 indexes. 0 => plugin name, 1 => class name
* @link http://book.cakephp.org/2.0/en/core-libraries/global-constants-and-functions.html#pluginSplit
*/
function pluginSplit($name, $dotAppend = false, $plugin = null) {
Expand Down

0 comments on commit b4a0182

Please sign in to comment.