Fixing String::insert() when $data is an empty array. Which was happe…

…ning in the dbo source tests.

cake/libs/string.php

@@ -229,6 +229,9 @@ function insert($str, $data, $options = array()) {
 		$options += $defaults;
 		$format = $options['format'];
 		$data = (array)$data;
+		if (empty($data)) {
+			return ($options['clean']) ? String::cleanInsert($str, $options) : $str;
+		}
 
 		if (!isset($format)) {
 			$format = sprintf(

cake/tests/cases/libs/string.test.php

@@ -71,6 +71,11 @@ function testMultipleUuidGeneration() {
  * @return void
  */
 	function testInsert() {
+		$string = 'some string';
+		$expected = 'some string';
+		$result = String::insert($string, array());
+		$this->assertEqual($result, $expected);
+
 		$string = '2 + 2 = :sum. Cake is :adjective.';
 		$expected = '2 + 2 = 4. Cake is yummy.';
 		$result = String::insert($string, array('sum' => '4', 'adjective' => 'yummy'));