Merge pull request #4927 from cakephp/issue-4924

Allow float 0 to be considered empty.
cakephp · Oct 19, 2014 · f9aaec9 · f9aaec9
2 parents 760dd50 + 7d398ee
commit f9aaec9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Validation/Validator.php b/src/Validation/Validator.php
@@ -481,7 +481,7 @@ protected function _canBeEmpty($field, $context) {
  * @return bool
  */
 	protected function _fieldIsEmpty($data) {
-		if (empty($data) && $data !== '0' && $data !== false && $data !== 0) {
+		if (empty($data) && $data !== '0' && $data !== false && $data !== 0 && $data !== 0.0) {
 			return true;
 		}
 		return false;

diff --git a/tests/TestCase/Validation/ValidatorTest.php b/tests/TestCase/Validation/ValidatorTest.php
@@ -373,6 +373,9 @@ public function testErrorsWithEmptyAllowed() {
 		$errors = $validator->errors(['title' => 0]);
 		$this->assertEmpty($errors);
 
+		$errors = $validator->errors(['title' => 0.0]);
+		$this->assertEmpty($errors);
+
 		$errors = $validator->errors(['title' => '0']);
 		$this->assertEmpty($errors);