Don't load missing plugins.

Instead we should throw an exception like other parts of the framework do.
cakephp · Jul 12, 2018 · fbd8a17 · fbd8a17
1 parent 11777be
commit fbd8a17
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Shell/Task/ExtractTask.php b/src/Shell/Task/ExtractTask.php
@@ -16,6 +16,7 @@
 
 use Cake\Console\Shell;
 use Cake\Core\App;
+use Cake\Core\Exception\MissingPluginException;
 use Cake\Core\Plugin;
 use Cake\Filesystem\File;
 use Cake\Filesystem\Folder;
@@ -169,7 +170,7 @@ public function main()
         } elseif (isset($this->params['plugin'])) {
             $plugin = Inflector::camelize($this->params['plugin']);
             if (!Plugin::isLoaded($plugin)) {
-                Plugin::load($plugin);
+                throw new MissingPluginException(['plugin' => $plugin]);
             }
             $this->_paths = [Plugin::classPath($plugin)];
             $this->params['plugin'] = $plugin;

diff --git a/tests/TestCase/Shell/Task/ExtractTaskTest.php b/tests/TestCase/Shell/Task/ExtractTaskTest.php
@@ -268,6 +268,7 @@ public function testExtractExcludePlugins()
     public function testExtractPlugin()
     {
         static::setAppNamespace();
+        $this->loadPlugins(['TestPlugin']);
 
         $this->Task = $this->getMockBuilder('Cake\Shell\Task\ExtractTask')
             ->setMethods(['_isExtractingApp', 'in', 'out', 'err', 'clear', '_stop'])
@@ -292,6 +293,7 @@ public function testExtractPlugin()
     public function testExtractVendoredPlugin()
     {
         static::setAppNamespace();
+        $this->loadPlugins(['Company/TestPluginThree']);
 
         $this->Task = $this->getMockBuilder('Cake\Shell\Task\ExtractTask')
             ->setMethods(['_isExtractingApp', 'in', 'out', 'err', 'clear', '_stop'])