New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for JSON request parsing in Enforcer #461
Open
Shiva953
wants to merge
2
commits into
casbin:master
Choose a base branch
from
Shiva953:feat-enable-json-request-parsing
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shiva953 <b22070@students.iitmandi.ac.in>
@nodece @Shivansh-yadav13 please review |
Shiva953
changed the title
[feature]Add support for JSON request parsing in Enforcer
feat: Add support for JSON request parsing in Enforcer
Nov 5, 2023
@Shiva953 fix CI: |
Signed-off-by: Shiva953 <b22070@students.iitmandi.ac.in>
hmm lol |
nodece
reviewed
Apr 11, 2024
@@ -23,6 +23,7 @@ import { FieldIndex } from './constants'; | |||
* Enforcer = ManagementEnforcer + RBAC API. | |||
*/ | |||
export class Enforcer extends ManagementEnforcer { | |||
private acceptJsonRequest = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you only add a variable, no logic checks.
Is it correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #460
This PR adds support for JSON request parsing in the Enforcer module. The new method
enableAcceptJsonRequest
has been implemented to facilitate parsing request properties as JSON strings which enhances the capability of the Enforcer to handle object ownership, improving the overall functionality and versatility of the system.