Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMG Heppy updates, 76X #69

Closed
wants to merge 130 commits into from

Conversation

gpetruc
Copy link

@gpetruc gpetruc commented Mar 7, 2016

Includes an update to CMSSW_7_6_3_patch2 since it's based on an Egamma branch that is rooted there.
A comparison of this PR with respect to Colin's heppy HEAD + CMSSW_7_6_3_patch2 can bee seen at gpetruc/cmssw@cbernet_heppy763_on_763patch2...cmg_heppy_76X_20160307

@arizzi

uhh2-bot and others added 30 commits June 21, 2015 19:53
Previous problems were found to be due to numerical effects in
pede. These are solved in >=rev137, which uses 'elimination'
instead of lagrangian multipliers.
In addition, switch from vector of doubles to LUT for PUM0 table.
…s-l1t-offline

* cms-l1t-offline/l1t-devel-CMSSW_7_6_0_pre1-CaloParamsUpdate:
  Refactor CaloParams into CaloParamsHelper

Conflicts:
	L1Trigger/L1TCalorimeter/src/PUSubtractionMethods.cc
	L1Trigger/L1TCalorimeter/src/firmware/Stage1Layer2JetAlgorithmImpHI.cc
	L1Trigger/L1TCalorimeter/src/firmware/Stage1Layer2SingleTrackHI.cc
* richard-cms/HIL1_FirmwareMatching_760p7:
  build fixes
  commit current HI status, will move to pre7 shortly
  use correct CaloParams values for HI algos
  centrality verbosity changes
  reorganize single track algo
  egamma verbosity and also iso/non-iso swap
  updates to verbosity for egammas
  change the verbosity
  use a tunable mask to zero the walls
  change verbosity levels
  switch to integer division
  switch back to 3x3 jet finder for tests
  turn on high verbosity for HI algos
  Refactor CaloParams into CaloParamsHelper

Conflicts:
	L1Trigger/L1TCalorimeter/test/SimL1Emulator_Stage1.py
* richard-cms/HIL1_FirmwareMatching_760p7:
  build fixes
  commit current HI status, will move to pre7 shortly
  use correct CaloParams values for HI algos
  centrality verbosity changes
  reorganize single track algo
  egamma verbosity and also iso/non-iso swap
  updates to verbosity for egammas
  change the verbosity
  use a tunable mask to zero the walls
  change verbosity levels
  switch to integer division
  switch back to 3x3 jet finder for tests
  turn on high verbosity for HI algos
  Refactor CaloParams into CaloParamsHelper
gpetruc and others added 20 commits February 22, 2016 11:40
Heppy Kalman Muon Corrections for 76X
…earings methods, always pass Et; improve debugging printouts
* fix a possible unreasonable correction when not in a known class
- update the scale and smearings to 76X re-reco
Updating ECAL scale and resolution corrections, and propagating to Heppy Electrons and Photons
@arizzi
Copy link

arizzi commented Mar 7, 2016

we had to migrate to patch2 too because of new JETID recipe.

Colin can you switch to 763patch2 ?

On Mon, Mar 7, 2016 at 2:22 PM, Giovanni Petrucciani <
notifications@github.com> wrote:

Includes an update to CMSSW_7_6_3_patch2 since it's based on an Egamma
branch that is rooted there.
A comparison of this PR with respect to Colin's heppy HEAD +
CMSSW_7_6_3_patch2 can bee seen at gpetruc@
cbernet_heppy763_on_763patch2...cmg_heppy_76X_20160307
gpetruc/cmssw@cbernet_heppy763_on_763patch2...cmg_heppy_76X_20160307

@arizzi https://github.com/arizzi

You can view, comment on, or merge this pull request online at:

#69
Commit Summary

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#69.

@arizzi
Copy link

arizzi commented Mar 11, 2016

@cbernet are you going to merge this?

@cbernet
Copy link
Owner

cbernet commented Mar 11, 2016

yes I will

@arizzi arizzi mentioned this pull request Mar 11, 2016
@cbernet
Copy link
Owner

cbernet commented Mar 11, 2016

Hi guys, I see that 764 is out since Tuesday, should I move to this release instead of 763patch2?

@arizzi
Copy link

arizzi commented Mar 11, 2016

@cbernet I'd rather prefer not to because it would imply migrating our stuff whil we want to launch asap a new ntuple production, but I'm flexible and can adapt.

@cbernet
Copy link
Owner

cbernet commented Mar 11, 2016

I agree let’s take our time.
I now have an heppy branch for 763patch2, I still have to have a look in details at Giovanni’s PR on top of this one.
Should be no big deal, I’ll probably be able to merge everything this afternoon, and I’ll let you know asap

C

Le 11 mars 2016 à 13:53, arizzi notifications@github.com a écrit :

@cbernet I'd rather prefer not to because it would imply migrating our stuff whil we want to launch asap a new ntuple production, but I'm flexible and can adapt.


Reply to this email directly or view it on GitHub.

@cbernet
Copy link
Owner

cbernet commented Mar 11, 2016

This PR is included in my new branch,
https://github.com/cbernet/cmssw/tree/heppy_7_6_3_patch2
So I'm closing it.
From now on, please send me PR to the new branch.

Also, I would like to send a pull request to CMSSW soon in the 76X release stream.
Do you want to add more things in the near future?

@cbernet cbernet closed this Mar 11, 2016
@gpetruc gpetruc deleted the cmg_heppy_76X_20160307 branch June 1, 2016 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet