Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TestConfigCommands for #14365 #805

Merged
merged 4 commits into from Feb 16, 2016
Merged

Add TestConfigCommands for #14365 #805

merged 4 commits into from Feb 16, 2016

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Jan 21, 2016

No description provided.

@jcsp jcsp changed the title Add TestConfigCommands fpr Add TestConfigCommands for #14365 Jan 21, 2016
@jcsp jcsp mentioned this pull request Jan 21, 2016
Merged
@jcsp
Copy link
Contributor Author

jcsp commented Jan 21, 2016

This tests ceph PR: ceph/ceph#7312

@gregsfortytwo
Copy link
Member

You reviewed this while looking at the Ceph PR, right @ukernel? :)

@gregsfortytwo
Copy link
Member

@jcsp:

gregf@rex004:~/src/ceph-qa-suite [master]$ pyflakes tasks/cephfs/test_config_commands.py
tasks/cephfs/test_config_commands.py:5: 'CommandFailedError' imported but unused

gregsfortytwo added a commit that referenced this pull request Feb 3, 2016
@gregsfortytwo
Merge remote-tracking branch 'origin/wip-14365' into greg-fs-testing
eac8c54 
#805

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
gregsfortytwo added a commit that referenced this pull request Feb 3, 2016
@gregsfortytwo
Merge remote-tracking branch 'origin/wip-14365' into greg-fs-testing
b6ff0f4 
#805

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
@gregsfortytwo gregsfortytwo assigned jcsp and unassigned gregsfortytwo Feb 4, 2016
@gregsfortytwo
Copy link
Member

Drat, I'm sorry @jcsp, but I missed a test failure when I merged the ceph branch (and forgot to merge this one). Running it in my latest test branch I'm seeing an assert in http://pulpito.ceph.com/gregf-2016-02-03_09:19:17-fs-greg-fs-testing-23---basic-mira/4588

existing dependency Client::client_lock (12) -> Objecter::rwlock (14) at:
2016-02-03 21:09:35.145789 7fcb11af5e80 0 existing intermediate dependency AdminSocket::m_lock (1) -> Client::client_lock (12) at:
2016-02-03 21:09:35.147807 7fcb11af5e80 0 new dependency Objecter::rwlock (14) -> AdminSocket::m_lock (1) creates a cycle at
ceph version 10.0.2-1645-g4daa934 (4daa934e6d2d50754149a876fb8bf5cef1f6c71d)
1: (AdminSocket::unregister_command(std::string)+0x3c) [0x7fcb1168655c]
2: (Objecter::shutdown()+0x6da) [0x7fcb1158a89a]
3: (Client::shutdown()+0x5ea) [0x7fcb114c36aa]
4: (main()+0x5d9) [0x7fcb114b03c9]
5: (__libc_start_main()+0xf5) [0x7fcb0f35dec5]
6: (()+0x177bb7) [0x7fcb114b3bb7]

And I also saw it on the previous test run: http://pulpito.ceph.com/gregf-2016-01-26_15:35:20-fs-greg-fs-testing-126---basic-mira/44982

Can you check that out and submit another PR to clean it up?

@jcsp
Copy link
Contributor Author

jcsp commented Feb 9, 2016

Related fix:
ceph/ceph#7581

@jcsp jcsp assigned gregsfortytwo and unassigned jcsp Feb 9, 2016
@jcsp jcsp mentioned this pull request Feb 9, 2016
Merged
John Spray added 4 commits February 10, 2016 12:22
tasks/cephfs: make FuseMount.admin_socket public
9fd891f 
For tests that specifically want to exercise an
asok operation (the test is responsible for
verifying that its mount object really is a
FuseMount and not a KernelMount)

Signed-off-by: John Spray <john.spray@redhat.com>
tasks/cephfs: optionally check result of fuse proc on umount
08c2876 
For cases where the client process successfully unmounts,
but then crashes before finishing.

Signed-off-by: John Spray <john.spray@redhat.com>
tasks/cephfs: run ceph-fuse in foreground
86b4231 
Previously was running this in background, which prevented
checking for nonzero exit codes.

Signed-off-by: John Spray <john.spray@redhat.com>
tasks/cephfs: add TestConfigCommands
17e310f 
Get some coverage on the otherwise rarely touched
injectargs and `config set` interfaces.

Fixes: #14365
Signed-off-by: John Spray <john.spray@redhat.com>
@gregsfortytwo gregsfortytwo merged commit 17e310f into master Feb 16, 2016
gregsfortytwo added a commit that referenced this pull request Feb 16, 2016
@gregsfortytwo
Merge remote-tracking branch 'origin/wip-14365' into greg-fs-testing
e54ad3b 
#805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gregsfortytwo gregsfortytwo

Labels
cephfs needs-qa wip-greg-testing
Projects
None yet
Milestone
No milestone
3 participants
@jcsp @gregsfortytwo @ukernel