mds, client: fix locking around handle_conf_change #7312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 21, 2016 13:29
Development clusters are the right place to enable performance-degrading correctness checks. Signed-off-by: John Spray <john.spray@redhat.com>
Because we acquire mds_lock inside asok handlers, we must not hold mds_lock while registering our commands. Fixes: ceph#14374 Signed-off-by: John Spray <john.spray@redhat.com>
This was a merge glitch between Ali's cmake updates and my VolumeClient PR. My PR was using the old TCMALLOC_LIBS vs. the new ALLOC_LIBS variable. Signed-off-by: John Spray <john.spray@redhat.com>
Fixes: ceph#14365 Signed-off-by: John Spray <john.spray@redhat.com>
Because by doing so we establish a dependency between client lock and admin socket lock. Signed-off-by: John Spray <john.spray@redhat.com>
We have to be careful about holding mds_lock while setting things up, and we also have to handle either locked or unlocked calls to handle_conf_change. Signed-off-by: John Spray <john.spray@redhat.com>
|
Tests: ceph/ceph-qa-suite#805 |
|
Please review this and the tests, @ukernel |
|
And mark them as needs-qa if they're good! :) |
|
looks good. I found a related bug #7343 |
gregsfortytwo
added a commit
that referenced
this pull request
Jan 26, 2016
…esting #7312 Reviewed-by: Yan, Zheng <zyan@redhat.com>
gregsfortytwo
added a commit
that referenced
this pull request
Jan 29, 2016
mds, client: fix locking around handle_conf_change Reviewed-by: Yan, Zheng <zyan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #7295 (commits also included in this branch)