Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/AsyncMessenger: remove unused method #10125

Merged

Conversation

stiopaa1
Copy link
Contributor

@stiopaa1 stiopaa1 commented Jul 4, 2016

Change the return type of function send_keepalive to void. It
doesn't make sense to return constant value(zero).

Signed-off-by: Michal Jarzabek stiopa@gmail.com

@yuyuyu101
Copy link
Member

I suggest we remove these lines since it doesn't have user

Signed-off-by: Michal Jarzabek <stiopa@gmail.com>
@stiopaa1 stiopaa1 force-pushed the msg_asyncmess_changeReturnTypeIntToVoid branch from ce15c99 to 85d0d35 Compare September 8, 2016 19:59
@ghost
Copy link

ghost commented Nov 21, 2016

jenkins test this please (no logs)

@tchaikov tchaikov changed the title msg/AsyncMessenger: change return type to void msg/AsyncMessenger: remove unused method "send_keepalive()" Feb 20, 2017
@tchaikov tchaikov changed the title msg/AsyncMessenger: remove unused method "send_keepalive()" msg/AsyncMessenger: remove unused method Feb 20, 2017
@tchaikov
Copy link
Contributor

@tchaikov tchaikov merged commit 0423b61 into ceph:master Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants