os/bluestore: introduce power 2 macros for block alignment and rounding #10128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macros for various sorts of alignment and rounding. So we can get rid of the annoying division and mod operation and simplify the blob/space access logic. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
1. pre-calculate r, so we don't have to do the division each loop, which is expensive. 2. make sure the extent to be allocated is within the block device size. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-2016-07-05
branch
from
d9503cd
to
664bae0
Compare
|
this fails --gtest_filter=ObjectStore/StoreTest.Synthetic/2 |
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-2016-07-05
branch
from
664bae0
to
67d9667
Compare
|
Fixed. Passed local testing: |
|
But I also observe that the master is suffering the below testing also: |
xiexingguo
added a commit
to xiexingguo/ceph
that referenced
this pull request
Mar 28, 2018
These macros are originally introduced in ceph#10128 and get replaced by ceph#19913. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
added a commit
to xiexingguo/ceph
that referenced
this pull request
Mar 28, 2018
These macros are originally introduced in ceph#10128 and get replaced by ceph#19913. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
votdev
pushed a commit
to votdev/ceph
that referenced
this pull request
Apr 3, 2018
These macros are originally introduced in ceph#10128 and get replaced by ceph#19913. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
votdev
pushed a commit
to votdev/ceph
that referenced
this pull request
Apr 5, 2018
These macros are originally introduced in ceph#10128 and get replaced by ceph#19913. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
votdev
pushed a commit
to votdev/ceph
that referenced
this pull request
Apr 9, 2018
These macros are originally introduced in ceph#10128 and get replaced by ceph#19913. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
votdev
pushed a commit
to votdev/ceph
that referenced
this pull request
Apr 9, 2018
These macros are originally introduced in ceph#10128 and get replaced by ceph#19913. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macros for various sorts of alignment and rounding.
So we can get rid of the annoying division and mod operation and simplify
the blob/space access logic.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn