jewel: mds: Deadlock on shutdown active rank while busy with metadata IO #10502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves a deadlock reported in i16042 where the thread calling MDSRankDispatcher::shutdown would hold the mds_lock while asynchronous callbacks in the Finisher would attempt to lock mds_lock. For simplicity, I merged the finisher stop with the messenger shutdown as both need the mds_lock dropped. Fixes: http://tracker.ceph.com/issues/16042 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit b1d6689) Conflicts: src/mds/MDSRank.cc trivial conflict in MDSRankDispatcher::shutdown()
|
test this please |
ghost
pushed a commit
that referenced
this pull request
Aug 8, 2016
…k while busy with metadata IO Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
Hey jenkins, test this please ! (bluefs crash) |
ghost
pushed a commit
that referenced
this pull request
Aug 9, 2016
…k while busy with metadata IO Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 12, 2016
…k while busy with metadata IO Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@jcsp does this backport look good to merge ? It passed the fs suite http://tracker.ceph.com/issues/16344#note-21 (except for unrelated valgrind failures and one transient failure that is, I believe, unrelated ). |
ghost
pushed a commit
that referenced
this pull request
Aug 16, 2016
…k while busy with metadata IO Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 17, 2016
…k while busy with metadata IO Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
…k while busy with metadata IO Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
…k while busy with metadata IO Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@dachary, I'll sign-off on this since John's on vacation another week. |
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16797