Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jewel: mds: Deadlock on shutdown active rank while busy with metadata IO #10502

Merged
1 commit merged into from Aug 23, 2016
Merged

jewel: mds: Deadlock on shutdown active rank while busy with metadata IO #10502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/mds/MDSRank.cc
View file
Open in desktop
Expand Up @@ -222,8 +222,6 @@ void MDSRankDispatcher::shutdown()
// threads block on IOs that require finisher to complete.
mdlog->shutdown();

finisher->stop(); // no flushing

// shut down cache
mdcache->shutdown();

Expand All @@ -236,9 +234,17 @@ void MDSRankDispatcher::shutdown()

progress_thread.shutdown();

// release mds_lock for finisher/messenger threads (e.g.
// MDSDaemon::ms_handle_reset called from Messenger).
mds_lock.Unlock();

finisher->stop(); // no flushing

// shut down messenger
messenger->shutdown();

mds_lock.Lock();

// Workaround unclean shutdown: HeartbeatMap will assert if
// worker is not removed (as we do in ~MDS), but ~MDS is not
// always called after suicide.
Expand Down