Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd: more cleanups #10548

Merged
merged 4 commits into from
Aug 8, 2016
Merged

osd: more cleanups #10548

merged 4 commits into from
Aug 8, 2016

Commits on Aug 2, 2016

  1. osd: kill redundant call of cancel_all_events() 

    The agent_timer.shutdown() method will call cancel_all_events()
within in a more safe and elegant way, so we don't have to
call it explicitly here.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
    @xiexingguo
    xiexingguo committed Aug 2, 2016
    Configuration menu
    Copy the full SHA
    9ce5028 View commit details
    Browse the repository at this point in the history

  2. osd: add sanity check for scrubs_active counter 

    To make sure there is no underflow and the scrub logic
works fine.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
    @xiexingguo
    xiexingguo committed Aug 2, 2016
    Configuration menu
    Copy the full SHA
    41b4c7a View commit details
    Browse the repository at this point in the history

  3. osd/ReplicatedPG: fix typo(from ECANCELLED to ECANCELED) 

    According to Linux Man pages:

  ECANCELED       Operation canceled (POSIX.1)

So ECANCELED is the preferred one.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
    @xiexingguo
    xiexingguo committed Aug 2, 2016
    Configuration menu
    Copy the full SHA
    420843a View commit details
    Browse the repository at this point in the history

  4. osd: initialize class_handler of OSD properly 

    The destructor of OSD will delete class_handler arbitrarily
and there are cases we'll fail to start an osd before we
load the class_handler correctly.

So it is safe to initialize class_handler to NULL as to
avoid access violation.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
    @xiexingguo
    xiexingguo committed Aug 2, 2016
    Configuration menu
    Copy the full SHA
    30cffa0 View commit details
    Browse the repository at this point in the history