osd: more cleanups #10548
Merged
osd: more cleanups #10548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The agent_timer.shutdown() method will call cancel_all_events() within in a more safe and elegant way, so we don't have to call it explicitly here. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
To make sure there is no underflow and the scrub logic works fine. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
According to Linux Man pages: ECANCELED Operation canceled (POSIX.1) So ECANCELED is the preferred one. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
The destructor of OSD will delete class_handler arbitrarily and there are cases we'll fail to start an osd before we load the class_handler correctly. So it is safe to initialize class_handler to NULL as to avoid access violation. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.