osd: drop unused variables/methods #10559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@athanatos More cleanups, please help to review. Thanks! |
| @@ -3572,7 +3567,7 @@ void OSD::handle_pg_peering_evt( | |||
| if (!pp->is_replicated() && role != pgid.shard) | |||
| role = -1; | |||
|
|
|||
| PG *pg = _create_lock_pg( | |||
| pg = _create_lock_pg( | |||
xiexingguo
force-pushed
the
xxg-wip-osd-2016-08-03
branch
from
877d74e
to
3bb84a9
Compare
Basically we don't allow a transaction to get too big, e.g., to avoid contiguously occupation of CPU. We break and queue the transaction here whenever we have collected osd_target_transaction_size temp objects. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
It is never used and I see no chance it will be used. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
When _have_pg() returns true, we drop the pg_map_lock and pg->lock() simultaneously. So theoretically the subsequent call to _lookup_lock_pg() can return NULL, although the chance is rare. Also, since we are going to call _lookup_lock_pg() anyway, we can call it directly, thus the _have_pg() method is totally unnecessary. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Hard code transaction size to be 300 is not good. Since we already introduce osd_target_transaction_size for the same purpose, we can use it directly here. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-osd-2016-08-03
branch
from
3bb84a9
to
7a1af57
Compare
|
@athanatos Fixed as you suggested. Please check again. Thanks! |
xiexingguo
force-pushed
the
xxg-wip-osd-2016-08-03
branch
from
7a1af57
to
cfe7b0f
Compare
For a better understanding since it can confuse newcommers. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-osd-2016-08-03
branch
from
cfe7b0f
to
dae43c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.