Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: drop unused variables/methods #10559

Merged
merged 5 commits into from
Aug 8, 2016

Commits on Aug 3, 2016

  1. osd: don't get transaction too big during clear_temp_objects()

    Basically we don't allow a transaction to get too big, e.g., to
    avoid contiguously occupation of CPU.
    
    We break and queue the transaction here whenever we have collected
    osd_target_transaction_size temp objects.
    
    Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
    xiexingguo committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    686ef2a View commit details
    Browse the repository at this point in the history
  2. osd: kill _lookup_pg() method

    It is never used and I see no chance it will be used.
    
    Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
    xiexingguo committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    5eccd8d View commit details
    Browse the repository at this point in the history
  3. osd: fix rare race while looking for a pg

    When _have_pg() returns true, we drop the pg_map_lock
    and pg->lock() simultaneously. So theoretically the
    subsequent call to _lookup_lock_pg() can return NULL,
    although the chance is rare.
    
    Also, since we are going to call _lookup_lock_pg() anyway,
    we can call it directly, thus the _have_pg() method is
    totally unnecessary.
    
    Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
    xiexingguo committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    8af1031 View commit details
    Browse the repository at this point in the history
  4. osd: use osd_target_transaction_size when batch removing objects

    Hard code transaction size to be 300 is not good. Since we already
    introduce osd_target_transaction_size for the same purpose, we can
    use it directly here.
    
    Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
    xiexingguo committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    00aeae8 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2016

  1. osd: add a comment for the purpose of pinned_maps

    For a better understanding since it can confuse newcommers.
    
    Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
    xiexingguo committed Aug 4, 2016
    Configuration menu
    Copy the full SHA
    dae43c7 View commit details
    Browse the repository at this point in the history