rgw: fix radosgw daemon core when reopen logs #10737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the rgw_user_st_syn thread use the pointer meta_mgr in RGWUserStatsCache::sync_all_users() fuction, so we should close the thread before delete the pointer in RGWRados::finalize() function when close storage before reopen_logs. Fixes: http://tracker.ceph.com/issues/17036 Signed-off-by: weiqiaomiao <wei.qiaomiao@zte.com.cn>
weiqiaomiao
force-pushed
the
wqm-wip-rgw-core
branch
from
7a52a0f
to
ea5d7fd
Compare
| @@ -3201,6 +3200,7 @@ void RGWRados::finalize() | |||
| if (cr_registry) { | |||
| cr_registry->put(); | |||
| } | |||
| delete meta_mgr; | |||
There was a problem hiding this comment.
does jewel suffer from this issue as well?
There was a problem hiding this comment.
although jewel don't enter this process when reopen_logs, but it may hit this problem when the RGWRealmReloader::reload() fuction is called(for example, change the master zone to a different zone).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
rgw_user_st_synthread use the pointermeta_mgrinRGWUserStatsCache::sync_all_users()fuction, so we should close the thread before delete the pointer inRGWRados::finalize()function when close storage before reopen_logs.Fixes: http://tracker.ceph.com/issues/17036
Signed-off-by: weiqiaomiao wei.qiaomiao@zte.com.cn