Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: fix radosgw daemon core when reopen logs #10737

Merged
merged 1 commit into from Aug 17, 2016
Merged

rgw: fix radosgw daemon core when reopen logs #10737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rgw/rgw_rados.cc
View file
Open in desktop
Expand Up @@ -3164,7 +3164,6 @@ void RGWRados::finalize()
data_notifier->stop();
delete data_notifier;
}
delete meta_mgr;
delete data_log;
if (async_rados) {
delete async_rados;
Expand Down Expand Up @@ -3201,6 +3200,7 @@ void RGWRados::finalize()
if (cr_registry) {
cr_registry->put();
}
delete meta_mgr;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does jewel suffer from this issue as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although jewel don't enter this process when reopen_logs, but it may hit this problem when the RGWRealmReloader::reload() fuction is called(for example, change the master zone to a different zone).

delete binfo_cache;
delete obj_tombstone_cache;
}
Expand Down