Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: Mantle: A Programmable Metadata Load Balancer #10887

Merged
merged 3 commits into from Oct 26, 2016

Conversation

michaelsevilla
Copy link
Contributor

@smithfarm smithfarm changed the title Mantle: A Programmable Metadata Load Balancer fs: Mantle: A Programmable Metadata Load Balancer Aug 28, 2016
@gregsfortytwo gregsfortytwo added cephfs Ceph File System needs-review labels Sep 6, 2016

#define dout_subsys ceph_subsys_mds
#define dout_subsys ceph_subsys_mds_balancer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want this: iirc the --debug-mds flag isn't a prefixish thing, so this change will silence all the balancer and migrator logs for people who currently set --debug-mds

@jcsp
Copy link
Contributor

jcsp commented Sep 9, 2016

This looks to be exactly what was discussed at the last CDM, so all of my comments are just detail things. At a high level: 👍

Does #7338 need poking along somehow?

@michaelsevilla
Copy link
Contributor Author

I already poked #7338 and @noahdesu is going to take care of it.

Dumb question: is it better to rebase (keep history clean but lose your comments) or just add more commits?

@jcsp
Copy link
Contributor

jcsp commented Sep 9, 2016

You can either add more commits (and rebase later before merge) or just do a straight history-squashing rebase.

Usually we leave comments on the "files changed" view (not individual commits) so that they survive a rebase, but I mistakenly put some on commits here -- my fault if they get lost in a rebase.

@gregsfortytwo
Copy link
Member

Luckily Github finally fixed that nonsense, at least as long as you navigate from the PR view into the commit (not sure if you just go straight to a commit). You can tell it's working because all the comments are on the diff, not on a commit. ;)

Personally I prefer commits prefixed with "SQUASH" that are intended to be rebase, as it makes life easier on the reviewer when there are follow-up comments, but that may just be me.

@gregsfortytwo
Copy link
Member

I see we did get some updated commits at some point that at least invalidated most comments. @jcsp, want to check this again? Be nice to get it in for @batrick's scaling tests.

@jcsp
Copy link
Contributor

jcsp commented Oct 24, 2016

This is good to go now from my point of view (apologies @michaelsevilla for delay). Please could you do a quick rebase as something else has touched CMakeLists.txt in the meantime

Introduces Mantle, a programmable metadata load balancer. Policies for making
migration decisions are written in Lua but the Migrator and Balancer modules
still do fragmentation and migration. If the Lua balancer fails, control falls
back to the original balancer implementation.

Signed-off-by: Michael Sevilla <mikesevilla3@gmail.com>
- add docs and sample balancer (greedy-spill)

Signed-off-by: Michael Sevilla <mikesevilla3@gmail.com>
- fix legacy encoding in mds map and add balancer to dumps
- fix blocking rados read and remove temporary files
- fix beacon message spamming

Signed-off-by: Michael Sevilla <mikesevilla3@gmail.com>
@michaelsevilla
Copy link
Contributor Author

Done -- @batrick: could you send me info on the scaling tests?

@batrick
Copy link
Member

batrick commented Oct 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants