librbd: potential double-unwatch of watch handle upon error #10974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trociny
pushed a commit
that referenced
this pull request
Sep 4, 2016
librbd: potential double-unwatch of watch handle upon error #10974
|
Still hitting an issue: http://pulpito.ceph.com/jdillaman-2016-09-04_16:08:56-rbd-wip-jd-testing---basic-smithi/400108 Watch error returned -ENOENT since image was deleted -- once the image was closed, it attempted to unwatch an already unwatched handle. |
Fixes: http://tracker.ceph.com/issues/17210 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
@trociny update pushed that recognizes that any errors from a rewatch imply the watch is unregistered |
trociny
pushed a commit
that referenced
this pull request
Sep 5, 2016
librbd: potential double-unwatch of watch handle upon error #10974
|
retest this please |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/17210
Signed-off-by: Jason Dillaman dillaman@redhat.com