fast denc encoding #11027
Merged
fast denc encoding #11027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return iterator(this, false); | ||
| } | ||
| iterator begin_deep() { | ||
| return iterator(this, false); |
liewegas
force-pushed
the
wip-denc
branch
3 times, most recently
from
f727ab9
to
0fe3cef
Compare
| // itype == internal type | ||
| // otype == external type, i.e., the type on the wire | ||
|
|
||
| // NOTE: set supported == 2 instead of true. This prevents these from |
There was a problem hiding this comment.
It would be useful to have a place in the comments where the values of the supported, featured, bounded, etc. are explicitly documented in a table.
Also the definition of "featured object" isn't immediately clear (and quite misleading). One line of comment where the term is first introduced would be hugely helpful.
|
@liewegas With first 4 commits (sharedblob::put() one causing crash) , memory leaks are resolved in my setup. |
liewegas
force-pushed
the
wip-denc
branch
6 times, most recently
from
37f9cd8
to
d9dab11
Compare
|
This looks about right to me. |
liewegas
force-pushed
the
wip-denc
branch
2 times, most recently
from
14b176b
to
b9c4380
Compare
…n terms of varint Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
#include it from encoding.h so that we can make old STL container helpers conditional on a new-style helper not being available. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
The bufferlist one is for internal use only. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
The BlueRocksEnv uses the append(const char *, size_t) appender. Ensure that this data is copied into a page-aligned buffer, and that we "pad" the write out with the remainder of the page. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Do the copy up-front. This is useful if we know our target buffer must be a contiguous buffer (e.g., because it will be passed to a kv store). Signed-off-by: Sage Weil <sage@redhat.com>
Avoid an inevitable rebuild() since we have to pass this to rocksdb as a single memory buffer anyway. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Back in 46522cf we broke the newline placement for the * lines. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.