New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted #11090
Conversation
There is an unrelated memory corruption issue within rbd-mirror on master -- need to fix that first before testing and merging this PR |
rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted #11090
@trociny Yes, so far so good. |
@dillaman "force promote" functional test passes locally for me but regularly fails on teuthology: http://pulpito.ceph.com/trociny-2016-09-17_15:04:54-rbd-wip-mgolub-testing---basic-smithi/ Note, I rose debugging level for rbd-mirror daemon in the qa-suite config, so you might find useful data in cluster1-client.mirror.*.log files. It looks I don't see image replayer handle_promoted handler being fired on tethology. |
@trociny Looks like journal::JournalMetadata::allocate_tag doesn't send out an update notification, so a forced promotion on an idle image would never be detected. |
@trociny repushed |
rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted #11090
rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted #11090
@dillaman Could you please rebase? |
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Fixes: http://tracker.ceph.com/issues/16974 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@trociny rebase pushed |
lgtm |
http://tracker.ceph.com/issues/16974