Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted #11090

Merged
merged 7 commits into from Sep 24, 2016

Conversation

dillaman
Copy link

@dillaman dillaman commented Sep 15, 2016

@dillaman
Copy link
Author

dillaman commented Sep 15, 2016

There is an unrelated memory corruption issue within rbd-mirror on master -- need to fix that first before testing and merging this PR

@trociny trociny self-assigned this Sep 16, 2016
@trociny
Copy link
Contributor

trociny commented Sep 16, 2016

@dillaman Does #11104 fix the memory corruption issue you mention here and [DNM] prefix can be removed?

trociny pushed a commit that referenced this pull request Sep 16, 2016
rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted #11090
@dillaman
Copy link
Author

@trociny Yes, so far so good.

@dillaman dillaman changed the title [DNM] rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted Sep 16, 2016
@trociny
Copy link
Contributor

trociny commented Sep 19, 2016

@dillaman "force promote" functional test passes locally for me but regularly fails on teuthology:

http://pulpito.ceph.com/trociny-2016-09-17_15:04:54-rbd-wip-mgolub-testing---basic-smithi/
http://pulpito.ceph.com/trociny-2016-09-17_15:04:37-rbd-wip-mgolub-testing---basic-mira/
http://pulpito.ceph.com/trociny-2016-09-17_15:04:21-rbd-wip-mgolub-testing---basic-vps/
http://pulpito.ceph.com/trociny-2016-09-17_15:04:04-rbd-wip-mgolub-testing---basic-vps/

Note, I rose debugging level for rbd-mirror daemon in the qa-suite config, so you might find useful data in cluster1-client.mirror.*.log files.

It looks I don't see image replayer handle_promoted handler being fired on tethology.

@dillaman
Copy link
Author

dillaman commented Sep 19, 2016

@trociny Looks like journal::JournalMetadata::allocate_tag doesn't send out an update notification, so a forced promotion on an idle image would never be detected.

@dillaman
Copy link
Author

@trociny repushed

trociny pushed a commit that referenced this pull request Sep 20, 2016
rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted #11090
trociny pushed a commit that referenced this pull request Sep 21, 2016
rbd-mirror: force-promoted image will remain R/O until rbd-mirror daemon restarted #11090
@trociny
Copy link
Contributor

trociny commented Sep 23, 2016

@dillaman Could you please rebase?

Jason Dillaman added 7 commits September 23, 2016 09:01
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Fixes: http://tracker.ceph.com/issues/16974
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@dillaman
Copy link
Author

@trociny rebase pushed

@trociny
Copy link
Contributor

trociny commented Sep 24, 2016

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants