Rgw lifecycle testing #11131
Merged
Rgw lifecycle testing #11131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
reviewed
Sep 19, 2016
| @@ -73,6 +73,9 @@ void *RGWLC::LCWorker::entry() { | |||
| } | |||
|
|
|||
| void RGWLC::initialize(CephContext *_cct, RGWRados *_store) { | |||
| #define COOKIE_LEN 16 | |||
| char buf[COOKIE_LEN + 1]; | |||
|
|
|||
There was a problem hiding this comment.
the for loop below has a char buf[32]; that shadows this one. could you either rename this, or move its declaration down to gen_rand_alphanumeric() so their scopes don't overlap?
dang
force-pushed
the
rgw-lifecycle-testing
branch
from
68118be
to
4a7505c
Compare
The lifecycle config lock was not setting a cookie. This means that all instances of that lock conflict, causing errors to be returned to the client. Set a unique cookie on each lock instance. Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
Add new config option - rgw_lc_debug_interval - that modifies the lifecycle algorithm. It treats days as being the configured number of seconds. This allows lifecycle to be tested in minutes, rather than days. Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
dang
force-pushed
the
rgw-lifecycle-testing
branch
from
4a7505c
to
77853a4
Compare
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.