rgw: obsolete 'radosgw-admin period prepare' command #11278
Conversation
gaurav36
force-pushed
the
wip-obsolete-rgw-admin-period-prepare
branch
from
d9481dc
to
a536a02
Compare
| if (strcmp(cmd, "prepare") == 0) { | ||
| cerr <<"command is obsolete; please check usage and/or man page" <<std::endl; | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
i don't think it's necessary to keep this message. could you also remove OPT_PERIOD_PREPARE from the enum?
There was a problem hiding this comment.
@cbodley Thank you
I will remove OPT_PERIOD_PREPARE in next patch.
If we remove the message then in next release if user execute period prepare command then he might wonder about period prepare command, means what happened to this command. Should we put any other message or completely remove this message (" command is obsolete; please check usage and/or man page") ?
There was a problem hiding this comment.
i appreciate you wanting to document the deprecation, but the reason i don't think it's necessary is that we've never documented this command (outside of radosgw-admin --help) as part of the multisite configuration process
There was a problem hiding this comment.
@cbodley thanks,
right, i will do it in next patch set.
gaurav36
force-pushed
the
wip-obsolete-rgw-admin-period-prepare
branch
from
a536a02
to
7b39482
Compare
|
@cbodley test case failure for this PR seems to be spurious failure. I saw same test failure on some other PR as well which have nothing to do with code change. |
| return OPT_PERIOD_PREPARE; | ||
| if (strcmp(cmd, "prepare") == 0) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
can remove this block entirely now
There was a problem hiding this comment.
@cbodley ahhh, i missed it.
All that the 'radosgw-admin period prepare' command does is create an empty period and write it to rados. When we added the staging period (see 'period get --staging'), uncommitted changes were written to that instead - so the 'period prepare' command became obsolete. It should be removed! Fixes: http://tracker.ceph.com/issues/17387 Reported-by: Casey Bodley <cbodley@redhat.com> Signed-off-by: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
gaurav36
force-pushed
the
wip-obsolete-rgw-admin-period-prepare
branch
from
7b39482
to
1508c70
Compare
|
thank you! |
All that the 'radosgw-admin period prepare' command does is create an
empty period and write it to rados. When we added the staging period
(see 'period get --staging'), uncommitted changes were written to that
instead - so the 'period prepare' command became obsolete. It should be
removed!
Fixes: http://tracker.ceph.com/issues/17387
Reported-by: Casey Bodley cbodley@redhat.com
Signed-off-by: Gaurav Kumar Garg garg.gaurav52@gmail.com