osd/PGBackend: fix collection_list shadow return value #11382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It will cause recovering data corrupt when collection_list return errno. |
|
@yuyuyu101 could you file a tracker ticket for this issue? it applies to hammer and jewel also, i think. |
|
lgtm. |
|
nice catch! |
|
@yuyuyu101 could you add a line like "Fixes: http://tracker.ceph.com/issues/17713" in your commit message? |
Fixes: http://tracker.ceph.com/issues/17713 Signed-off-by: Haomai Wang <haomai@xsky.com>
yuyuyu101
force-pushed
the
wip-fix-shadow
branch
from
89a175f
to
8a53a60
Compare
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haomai Wang haomai@xsky.com