New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jewel: rbd: krbd-related CLI patches #11400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idryomov
changed the title
Backport krbd-related CLI patches
jewel: backport krbd-related CLI patches
Oct 10, 2016
ghost
changed the title
jewel: backport krbd-related CLI patches
jewel: krbd-related CLI patches
Oct 11, 2016
ghost
self-assigned this
Oct 11, 2016
ghost
added
the
bug-fix
label
Oct 11, 2016
@idryomov good to merge with a description of the krbd test that was run to verify it does work. Reviewed-by: Loic Dachary <ldachary@redhat.com> |
Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit e857b78)
Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit ba8f9ee)
Reuse rbd map -o infrastructure to expose rbd unmap options in a similar fashion. Currently it's just one bool option, but we may need more in the future. Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 620f5e1) Conflicts: doc/man/8/rbd.rst [ PR #9151 ("rbd: add methods to set and get snapshot limits") not in jewel ]
idryomov
force-pushed
the
wip-rbd-cli-jewel
branch
from
October 11, 2016 08:53
aacb112
to
494687b
Compare
Repushed with conflict descriptions. |
These commits allow passing certain options to the rbd kernel module and don't bring in any new functionality. Tested manually by myself. |
theanalyst
changed the title
jewel: krbd-related CLI patches
"jewel: rbd: krbd-related CLI patches"
Nov 17, 2016
theanalyst
changed the title
"jewel: rbd: krbd-related CLI patches"
jewel: rbd: krbd-related CLI patches
Nov 17, 2016
This was referenced Jun 21, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17555