doc: Update install-ceph-gateway.rst #11432
Conversation
| @@ -510,24 +510,24 @@ Execute the following steps: | |||
|
|
|||
| #. Add the following contents to the file:: | |||
|
|
|||
| import boto | |||
There was a problem hiding this comment.
i don't think we should remove import boto. as boto.connect_s3(...) will fail.
There was a problem hiding this comment.
I think it's superfluous. I checked it btw, and it works. I used PyCharm which says it's an unused import. If you insist we can easily put it back. My main gripe is with the fact that the script simply does not run when you copy paste it, and I've been burnt by it twice now.
There was a problem hiding this comment.
@hansbogert. okay, i trust you. but how come python knows what boto is without this statement. weird...
There was a problem hiding this comment.
Couldn't really stand it as well so I looked it up. connect_s3 is defined in the __init__.py of top level of the boto package, which gets read even when you import a subpackage like boto.s3.connection
There was a problem hiding this comment.
Btw, do I need to sign when I commit something like this? I am not familiar with the linux kernel's process of signage, which you guys seem to be following.
There was a problem hiding this comment.
@hansbogert ahh, that explains. =)
you don't need to sign an agreement to contribute to Ceph. all you need to do is to follow https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#signing-contributions . in other words, please put this line at the end of your commit message.
Signed-off-by: Hans van den Bogert <your mail address here>
hansbogert
force-pushed
the
patch-3
branch
3 times, most recently
from
24d754f
to
3463174
Compare
|
There is one error with the automated tests. Unlikely this is of my doing, but should I rebase? |
|
@hansbogert no, it's a known issue. and the last thing, could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#preparing-and-sending-patches, in your case, it would be "doc: ". |
Make the s3test.py script PIP-8 complaint, and more importantly it no longer fails because of the wrong indentation on the line of the for-loop. Signed-off-by: Hans van den Bogert <hansbogert@gmail.com>
|
Well, this trivial patch served as good pilot for contributing to Ceph. Hope all is well now. |
theanalyst
changed the title
Make the s3test.py script PIP-8 compliant, and more importantly it no longer fails because of the wrong indentation on the line of the for-loop