os/bluestore: GC infra refactor, more UTs and GC range calculation fixes #11482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifed01
force-pushed
the
wip-bluestore-gc-fixes2
branch
from
ce917c7
to
57bf13a
Compare
liewegas
requested changes
Oct 13, 2016
| @@ -735,6 +735,18 @@ class BlueStore : public ObjectStore, | |||
| }; | |||
| typedef boost::intrusive_ptr<Onode> OnodeRef; | |||
|
|
|||
| //Made a specific class to be able to verify GC logics in Unit Tests | |||
| struct GarbageCollector { | |||
There was a problem hiding this comment.
I think it's simpler to just make this a method of ExtentMap, which already includes several unit tests in test_bluestore_types.cc
There was a problem hiding this comment.
Yeah, that's better...
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
ifed01
force-pushed
the
wip-bluestore-gc-fixes2
branch
from
57bf13a
to
c4344dc
Compare
added 2 commits
October 14, 2016 12:39
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
ifed01
force-pushed
the
wip-bluestore-gc-fixes2
branch
from
c4344dc
to
47c44a2
Compare
|
@liewegas - fixed |
liewegas
approved these changes
Oct 14, 2016
dalgaaf
pushed a commit
to dalgaaf/ceph
that referenced
this pull request
Apr 26, 2018
Client may flush and drop caps at the same time. If client need to send cap reconnect before the caps get flushed. The issued caps in the cap reconnect does not include the flushing caps. When choosing lock states, MDS only consider the issued caps in cap reconnect, it may choose wrong states. Fixes: ceph#11482 Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit ce9a596)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Fedotov ifedotov@mirantis.com