os/bluestore: use iterator for erase() method directly #11490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there is duplicate write_onode call for _do_truncate and _do_clone_range too. |
|
I'm not completely sure if this duplication's worth fixing but I'd prefer to have ALL write_onode calls at the same level for the sake of uniformity, i.e. either at entry points (_zero, _truncate, _clone, etc) or at some underlying ones (_do_zero, _do_truncate, _do_clone_range, etc). Just IMHO though... |
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-1014
branch
from
4c8969f
to
7a16de7
Compare
xiexingguo
changed the title
|
@ifed01 I am with you. Dropped that change. |
|
@ifed01 @xiaoxichen agreed on being consistent. Probably do*.... in a handful of cases that will include a duplicate insert, but it's probably safer? No strong preference though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.