cmake: link tests against static librados #11575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so tests referencing internal symbols can use librados_a instead of librados to avoid violating ODR (one definition rule). Fixes: http://tracker.ceph.com/issues/17260 Signed-off-by: Kefu Chai <kchai@redhat.com>
Fixes: http://tracker.ceph.com/issues/17260 Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
so no need to put add_dependencies() explicitly. Signed-off-by: Kefu Chai <kchai@redhat.com>
prior to this change, librbd tests link against librados_api_obj and librados_objs, but since librados_a offers all the goodies, we can just link against it instead. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
great ! Reviewed-by: Loic Dachary <ldachary@redhat.com> |
|
looks good to me! |
|
lgtm - would like to see the modified tests passing under teuthology. |
|
|
all passed. http://pulpito.ceph.com/kchai-2016-10-21_03:33:58-rbd-master---basic-mira is the comparison group of http://pulpito.ceph.com/kchai-2016-10-21_03:28:59-rbd-wip-17260---basic-mira/, it passes also. but considering tracker#17260 is a racing issue, it's possible that the test passes some times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/17260