Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: link tests against static librados #11575

Merged
merged 6 commits into from Oct 21, 2016
Merged

cmake: link tests against static librados #11575

merged 6 commits into from Oct 21, 2016

Commits on Oct 20, 2016

  1. cmake: always create static lib librados_a 

    so tests referencing internal symbols can use librados_a instead of
librados to avoid violating ODR (one definition rule).

Fixes: http://tracker.ceph.com/issues/17260
Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Oct 20, 2016
    Copy the full SHA
    8362c5f View commit details
    Browse the repository at this point in the history

  2. cmake: link tests against static librados 

    Fixes: http://tracker.ceph.com/issues/17260
Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Oct 20, 2016
    Copy the full SHA
    711b394 View commit details
    Browse the repository at this point in the history

  3. cmake: do not link against global if not necessary 

    Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Oct 20, 2016
    Copy the full SHA
    84d1f04 View commit details
    Browse the repository at this point in the history

  4. cmake: librados depends on osdc implicitly 

    so no need to put add_dependencies() explicitly.

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Oct 20, 2016
    Copy the full SHA
    f28481a View commit details
    Browse the repository at this point in the history

  5. cmake: link against rados_a instead of its objs 

    prior to this change, librbd tests link against librados_api_obj and
librados_objs, but since librados_a offers all the goodies, we can
just link against it instead.

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Oct 20, 2016
    Copy the full SHA
    16dda30 View commit details
    Browse the repository at this point in the history

  6. test/encoding: do not include unused headers 

    Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Oct 20, 2016
    Copy the full SHA
    e777200 View commit details
    Browse the repository at this point in the history