ceph-disk: allow using a regular file as a journal #11619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of a missing return, ceph-disk prepare would fail if given a regular file as a journal. If the journal file does not exist, ceph-disk will create it but fail to ensure that the ceph user owns it. The symlink to the journal file is not set when the journal file is specified on the command line and the journal file does not exist at all. The ceph-osd daemon will silently create it as a file but it will not be the file given in argument. Add a test case to verify using a regular file as a journal works as expected. Fixes: http://tracker.ceph.com/issues/17662 Signed-off-by: Jayashree Candadai <jayaajay@indiana.edu> Signed-off-by: Loic Dachary <ldachary@redhat.com>
ghost
changed the title
ghost
mentioned this pull request
|
jenkins test this please (general jenkins failure) |
teuthology-suite -k distro --verbose --suite ceph-disk --suite-branch master --ceph wip-17662-ceph-disk --machine-type vps --priority 101 machine_types/vps.yaml |
|
@cbodley would you mind reviewing this ? I'm asking because you took an interest into this. But feel free to decline and I'll ask someone else ;-) Note that it passed the ceph-disk suite above. |
|
@tchaikov if you have time to review this quickly it could make it to 10.2.4. Otherwise it's not a big deal: it has been there for some time now anyway :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17662