Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/OSDMap.cc: fix duplicated assignment for new_blacklist_entries #11799

Merged
merged 1 commit into from Nov 14, 2016

Conversation

KerLiu
Copy link

@KerLiu KerLiu commented Nov 5, 2016

Signed-off-by: Ker Liu kerliu818@gmail.com

@KerLiu KerLiu changed the title osd/OSDMap.cc: fix dup assignment for new_blacklist_entries osd/OSDMap.cc: fix duplicated assignment for new_blacklist_entries Nov 5, 2016
@KerLiu
Copy link
Author

KerLiu commented Nov 5, 2016

@tchaikov
please abandon previous #11799, I re-submitted it with git bash.
sorry for the inconveniences.

@tchaikov
Copy link
Contributor

tchaikov commented Nov 6, 2016

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes

could you add a "Signed-off-by" line at the end of your commit message? "git commit -s" will do the trick for you. see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#1-sign-your-work

Signed-off-by: Ker Liu kerliu818@gmail.com
@KerLiu
Copy link
Author

KerLiu commented Nov 6, 2016

@tchaikov
Done, thanks a lot for your support!

@tchaikov
Copy link
Contributor

tchaikov commented Nov 6, 2016

and the title of your commit message is misleading, instead of "fixing" things, it "simplifies" the loop by replacing it with a "insert()" call.

@tchaikov tchaikov self-assigned this Nov 6, 2016
@KerLiu
Copy link
Author

KerLiu commented Nov 7, 2016

before my code change, the variable "new_blacklist_entries" will be assigned to "true" many times based on the size of new_blacklist, it's duplicated assignment, my code change is to fix it, only do one time assignment.

@tchaikov
Copy link
Contributor

tchaikov commented Nov 7, 2016

oh, right! sorry, i missed it!

Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchaikov tchaikov merged commit 7d6fa8d into ceph:master Nov 14, 2016
@tchaikov
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants