-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osd/OSDMap.cc: fix duplicated assignment for new_blacklist_entries #11799
Conversation
could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes could you add a " |
Signed-off-by: Ker Liu kerliu818@gmail.com
11f01ad
to
f7a90c1
Compare
@tchaikov |
and the title of your commit message is misleading, instead of "fixing" things, it "simplifies" the loop by replacing it with a "insert()" call. |
before my code change, the variable "new_blacklist_entries" will be assigned to "true" many times based on the size of new_blacklist, it's duplicated assignment, my code change is to fix it, only do one time assignment. |
oh, right! sorry, i missed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Ker Liu kerliu818@gmail.com