os/bluestore: speed up omap-key generation for same onode #11807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can probably do even better by reusing the same string (at prefix scope) and truncating it to 8+1 each pass through the loop. That avoids the memory copy and (likely) an allocation. |
xiexingguo
force-pushed
the
xxg-wip-bs-1107
branch
from
f4fb6a8
to
db769dc
Compare
This is useful if we have to batch-process omap kvs. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
@liewegas Fixed. |
xiexingguo
added a commit
to xiexingguo/ceph
that referenced
this pull request
Nov 10, 2016
…ths) In ceph#11807 we only modify the write paths, this patch fixes the read parts too, which are more time-sensitive. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful if we have to batch-process omap kvs.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn