os/bluestore: reap ioc when stopping aio_thread. #11811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you hit this memory leak in practice? I would be inclined to put reap_ioc() at teh end of _aio_thread() outside of the loop, but either there or where you put it it doesn't help if you set aio_loop while aios are still in flight... which is I think the only case where the leak would happen. To address that, you need to flush before shutting down... |
there is possibillity that reap_ioc don't excute when stopping aio_thread. so add reap_ioc after aio_thread is stopped. Signed-off-by: Haodong Tang <haodong.tang@intel.com>
tanghaodong25
force-pushed
the
reap-ioc-wip
branch
from
f10d55f
to
d13b2b3
Compare
|
@liewegas I'm not sure I understand you correctly, Why are there aios in flight when calling aio_stop? aio finished before ioc is pushed to ioc_reap_queue. |
liewegas
approved these changes
Nov 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is possibillity that reap_ioc don't excute when stopping
aio_thread. so add reap_ioc after aio_thread is stopped.
Signed-off-by: Haodong Tang haodong.tang@intel.com