os/bluestore: kill dead gc-related counters #12065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the gc logic is deprecated by ceph#12042 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
and use the new method to simplify code. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
jenkins test this please (asok) |
xiexingguo
force-pushed
the
xxg-wip-kill-gc-counters
branch
from
aa5599a
to
9ddbfa0
Compare
…ompression Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-kill-gc-counters
branch
from
9ddbfa0
to
fdaef67
Compare
liewegas
approved these changes
Nov 18, 2016
ifed01
reviewed
Nov 18, 2016
| @@ -1280,9 +1280,8 @@ ostream& operator<<(ostream& out, const BlueStore::SharedBlob& sb) | |||
| return out << ")"; | |||
| } | |||
|
|
|||
| BlueStore::SharedBlob::SharedBlob(uint64_t i, const string& k, Cache *c) | |||
There was a problem hiding this comment.
I'd prefer a more robust change that introduce a ctor without sbid/key assignment and sbid setter that assigns both sbid and key(the latter to be calculated internally). Additional ctor that assigns sbid/key via the introduced setter is OK too. General idea here is to have an SharedBlob interface that ensures consistent internal state, i.e. sbid and key are assigned all together.
There was a problem hiding this comment.
That would be a bit nicer, yeah.. It's just the open_shared_blob() caller that should use a new ctor, and the new ctor should do the get_shared_blob_key() call
xiexingguo
force-pushed
the
xxg-wip-kill-gc-counters
branch
2 times, most recently
from
9d3854d
to
44eaa02
Compare
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the gc logic is deprecated by #12042
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn