tests: save 9 characters for asok paths #12066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
lgtm once jenkins returns happily. |
For vstart.sh powered tests, save 9 characters in the path name by replacing testdir/test- with td/t- 60 characters imposed by jenkins 9 characters for src/test 5 characters for td/t- 33 left (instead of 24) for the test to create asok such as out/client.admin.25327.asok Moving these files outside of the build directory is a bad idea because tests should only create/use files within the builddir and not write outside of this directory. Doing so would make things more complicated for cleanup in case the test fail and create other problems as a consequence (filling out disk space, conflicting directories between runs etc.). For ceph-helpers.sh tests replace testdir with td, saving 5 characters. This is not strictly necessary but keeps the directory names consistent: if the developer wants to get rid of all the test leftovers, it is enough to remove the a single directory: td. Fixes: http://tracker.ceph.com/issues/16014 Signed-off-by: Loic Dachary <loic@dachary.org>
|
@tchaikov I updated the pull request to also rename testdir into td in ceph-helpers. Otherwise make check would create two directories : td and testdir. The reason for creating the testdir directory was to make it easier to remove all tests leftovers. We don't want to return to a situation where there are multiple directories to worry about. Does that look sensible ? |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16014