Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: save 9 characters for asok paths #12066

Merged
1 commit merged into from Nov 18, 2016
Merged

tests: save 9 characters for asok paths #12066

1 commit merged into from Nov 18, 2016

Commits on Nov 18, 2016

  1. tests: save 9 characters for asok paths

    For vstart.sh powered tests, save 9 characters in the path name
    by replacing testdir/test- with td/t-
    
    60 characters imposed by jenkins
    9 characters for src/test
    5 characters for td/t-
    
    33 left (instead of 24) for the test to create asok such as out/client.admin.25327.asok
    
    Moving these files outside of the build directory is a bad idea because
    tests should only create/use files within the builddir and not write
    outside of this directory. Doing so would make things more complicated
    for cleanup in case the test fail and create other problems as a
    consequence (filling out disk space, conflicting directories between
    runs etc.).
    
    For ceph-helpers.sh tests replace testdir with td, saving 5 characters.
    This is not strictly necessary but keeps the directory names consistent:
    if the developer wants to get rid of all the test leftovers, it is
    enough to remove the a single directory: td.
    
    Fixes: http://tracker.ceph.com/issues/16014
    
    Signed-off-by: Loic Dachary <loic@dachary.org>
    ldachary committed Nov 18, 2016
    Copy the full SHA
    cd72ff9 View commit details
    Browse the repository at this point in the history