New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw: move compression config into zone placement #12113
Conversation
the new doc can be viewed here: http://docs.ceph.com/docs/wip-rgw-zone-compression/radosgw/compression/ |
17d1aaf
to
83888f7
Compare
@oritwas could you help review please? |
adding @yehudasa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@cbodley actually, maybe we want to have this as part of the specific placement target config, and not globally per zone? |
@cbodley , I think making it part of specific placement target config sounds useful. |
adding it to placement targets does make sense i'd prefer not to require admins to edit their zone json to set these, so new radosgw-admin commands to add/remove/edit placement targets would be nice. and the placement target stuff is only documented under are these changes in scope for the kraken rc? or should the compression doc just say |
83888f7
to
b0f1a6a
Compare
tested with a custom multisite cluster, with compression enabled thusly:
|
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
b0f1a6a
to
ceeb442
Compare
rebased after merge of #12242 and removed [DNM] tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This replaces the
rgw_compression_type
config option with an entry in the zone configuration, which can be set with the--compression=
option toradosgw-admin zone create
orzone modify
.Also adds some new documentation.