Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: move compression config into zone placement #12113

Merged
merged 4 commits into from Dec 1, 2016

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Nov 21, 2016

This replaces the rgw_compression_type config option with an entry in the zone configuration, which can be set with the --compression= option to radosgw-admin zone create or zone modify.

Also adds some new documentation.

@cbodley
Copy link
Contributor Author

cbodley commented Nov 22, 2016

the new doc can be viewed here: http://docs.ceph.com/docs/wip-rgw-zone-compression/radosgw/compression/

@cbodley
Copy link
Contributor Author

cbodley commented Nov 28, 2016

@oritwas could you help review please?

@cbodley
Copy link
Contributor Author

cbodley commented Nov 29, 2016

adding @yehudasa

@cbodley cbodley added this to the kraken milestone Nov 29, 2016
yehudasa
yehudasa previously approved these changes Nov 29, 2016
Copy link
Member

@yehudasa yehudasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yehudasa
Copy link
Member

@cbodley actually, maybe we want to have this as part of the specific placement target config, and not globally per zone?

@yehudasa yehudasa dismissed their stale review November 29, 2016 17:11

open question

@oritwas
Copy link
Member

oritwas commented Nov 29, 2016

@cbodley , I think making it part of specific placement target config sounds useful.

@cbodley
Copy link
Contributor Author

cbodley commented Nov 29, 2016

@cbodley actually, maybe we want to have this as part of the specific placement target config, and not globally per zone?

adding it to placement targets does make sense

i'd prefer not to require admins to edit their zone json to set these, so new radosgw-admin commands to add/remove/edit placement targets would be nice. and the placement target stuff is only documented under Regions: Set a Region in config-ref.rst - that stuff really needs to be updated to reflect the new multisite terminology (and probably moved into multisite.rst)

are these changes in scope for the kraken rc? or should the compression doc just say radosgw-admin zone get -> [edit json] -> zone set for now?

@cbodley cbodley changed the title rgw: move compression config into zone [DNM] rgw: move compression config into zone Nov 30, 2016
@cbodley
Copy link
Contributor Author

cbodley commented Nov 30, 2016

tested with a custom multisite cluster, with compression enabled thusly:

radosgw-admin zone placement modify --rgw-zone na-1 --placement-id=default-placement --compression=random

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley cbodley changed the title [DNM] rgw: move compression config into zone rgw: move compression config into zone placement Dec 1, 2016
@cbodley
Copy link
Contributor Author

cbodley commented Dec 1, 2016

rebased after merge of #12242 and removed [DNM] tag

Copy link
Member

@yehudasa yehudasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yehudasa yehudasa merged commit 8e5bb76 into master Dec 1, 2016
@cbodley cbodley deleted the wip-rgw-zone-compression branch December 1, 2016 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants