jewel: test fails due to The UNIX domain socket path #12151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For vstart.sh powered tests, save 9 characters in the path name by replacing testdir/test- with td/t- 60 characters imposed by jenkins 9 characters for src/test 5 characters for td/t- 33 left (instead of 24) for the test to create asok such as out/client.admin.25327.asok Moving these files outside of the build directory is a bad idea because tests should only create/use files within the builddir and not write outside of this directory. Doing so would make things more complicated for cleanup in case the test fail and create other problems as a consequence (filling out disk space, conflicting directories between runs etc.). For ceph-helpers.sh tests replace testdir with td, saving 5 characters. This is not strictly necessary but keeps the directory names consistent: if the developer wants to get rid of all the test leftovers, it is enough to remove the a single directory: td. Fixes: http://tracker.ceph.com/issues/16014 Signed-off-by: Loic Dachary <loic@dachary.org> (cherry picked from commit cd72ff9) Conflicts: .gitignore : test directories are not ignored in jewel src/test/vstart_wrapper.sh : trivial context resolution
ghost
self-assigned this
ghost
changed the base branch from
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2016
…ocket path Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@tchaikov does this backport look good to merge ? It passed the rados (http://tracker.ceph.com/issues/17851#note-12) suite. It also passed the upgrade/jewel-x and upgrade/hammer-x (http://tracker.ceph.com/issues/17851#note-15) suites. Note that it won't be included in 10.2.4, reason why it targets jewel-next. |
ghost
pushed a commit
that referenced
this pull request
Dec 5, 2016
…ocket path Reviewed-by: Loic Dachary <ldachary@redhat.com>
tchaikov
approved these changes
Dec 6, 2016
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18011