bufferlist: cleanup semantical wrong for bufferlist::append #12247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Dec 1, 2016
| @@ -1791,7 +1791,7 @@ static simple_spinlock_t buffer_debug_lock = SIMPLE_SPINLOCK_INITIALIZER; | |||
| if (gap > len) gap = len; | |||
| //cout << "append first char is " << data[0] << ", last char is " << data[len-1] << std::endl; | |||
| append_buffer.append(data, gap); | |||
| append(append_buffer, append_buffer.end() - gap, gap); // add segment to the list | |||
| append(append_buffer, append_buffer.length() - gap, gap); // add segment to the list | |||
There was a problem hiding this comment.
@YankunLi this issue impacts both hammer and jewel, could you file a ticket on tracker? and put more details in the commit message? then add a test in src/test/bufferlist.cc. also, please add a "Fixes:" line at end of your commit message to connect this commit to the tracker ticket.
this is just semantically wrong. as we never call append_buffer.set_offset(), so the append_buffer._offset is always 0. in other words, append_buffer.length() == append_buffer.end().
|
@YankunLi could you update the commit message, to note that this is more a cleanup than a fix? other than the commit message, lgtm. |
|
@tchaikov OK, thinks, |
this is just semantically wrong. as append_buffer.set_offset() was called, so append_buffer._off is always 0. in other words, append_buffer.length() == append_buffer.end(). using append_buffer. length() is better in here. Signed-off-by: Yankun Li <lioveni99@gmail.com>
YankunLi
force-pushed
the
fix_bf_append_parameter
branch
from
a5a7551
to
8e1066e
Compare
YankunLi
changed the title
tchaikov
approved these changes
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yankun Li lioveni99@gmail.com