include/fs_types: fix unsigned integer overflow #12440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stats image has (stripe_count * object_size) > UINT32_MAX results following exception: ... 5: (()+0xc3391) [0x7f720e638391] 6: (librbd::Image::stat(rbd_image_info_t&, unsigned long)+0x46) [0x7f720e5d1fd6] 7: (rbd::action::info::execute(boost::program_options::variables_map const&)+0x194) [0x7f7218266744] 8: (rbd::Shell::execute(std::vector<char const*, std::allocator<char const*> > const&)+0x87d) [0x7f721823c1bd] 9: (main()+0x72) [0x7f721820b4c2] ... Floating point exception (core dumped) Signed-off-by: runsisi <runsisi@zte.com.cn>
liewegas
approved these changes
Dec 12, 2016
|
@runsisi can I ask what your stripe unit / count are currently configured at? I'm just wondering the utility of such a large stripe period (not discounting that this is a bug). |
|
@dillaman it was set by our test engineer by accident |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stats image has (
stripe_count*object_size) >UINT32_MAXresults following exception:Signed-off-by: runsisi runsisi@zte.com.cn