client: fix potential buffer overflow #12515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2016 15:03
Trace::peek_string try to fill char *buf without any length check. I think string buf is the better way to handle it. Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
|
@jcsp Hmm this Trace code was added in the beginning so that I could capture a workload with ceph-fuse and replay it with SyntheticClient. We might want to just rip it out... |
liewegas
approved these changes
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trace::peek_string try to fill char *buf without any length check.
I think string buf is the better way to handle it.
Signed-off-by: Yunchuan Wen yunchuan.wen@kylin-cloud.com