osd/ECBackend: Send write message to peers first, then do local write #12522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like ReplicatedBackend did, this will improve write performance. Signed-off-by: huangjun <hjwsm1989@gmail.com>
|
as discussed in #11888 |
|
@athanatos please review it |
|
I'm really not convinced that this makes a difference. The local write and message sends here are async. |
|
Please reopen if there is evidence that it makes a difference. |
|
With bluestore a non-trivial amount of work is now happening in queue_transaction (everything but io). Is there a downside to doing this? It can't hurt |
|
Ok, that's a valid reason! |
|
did the failed test related to this PR? |
|
retest this please |
liewegas
approved these changes
Dec 29, 2016
liewegas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like ReplicatedBackend did, this will improve write performance.
Signed-off-by: huangjun hjwsm1989@gmail.com