New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osd/ReplicatedBackend: do not set omap header if it is empty #12612
Conversation
Signed-off-by: fangyuxiang fang.yuxiang@eisoo.com |
you should add the "Signed-off-by: xxx" line to your commit meesage, |
and dont close/reopen the pr, |
a134088
to
b3ca8a5
Compare
@hjwsm1989 thx |
@hjwsm1989 could you tell me how can i invite a reviewer for this pr? thx |
Hi, sage could you review for me? first PR, thx :-) |
could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it would be "ReplicatedBackend:". and you could shorten the title of your commit message to something like:
and put more details in the body of the commit message. also, you might want to add brackets around your mail address in your commit message like
"git commit -s" will do this for you. |
@tchaikov ok, thanks for your remind |
b3ca8a5
to
0b573bb
Compare
In replicatedpg backfill, objects have no omap header or keys previously, but an empty omap header will be inserted when they are pushed to replica, which leads leveldb performance degrade seriously when cluster has huge number of objects. so my opinion is that we does't insert omap header if is size is zero when handle PushOp in recovery. Signed-off-by: fang yuxiang <fang.yuxiang@eisoo.com>
0b573bb
to
c0ddd39
Compare
@tchaikov amended the commit message as the rule, thx |
In replicatedpg backfill, objects have no omap header or keys previously, but an empty omap header will be inserted when they are pushed to replica, which leads leveldb performance degrade seriously when cluster has huge number of objects.
so my opinion is that we does't insert omap header if is size is zero when handle PushOp in recovery.
Signed-off-by: fangyuxiang fang.yuxiang@eisoo.com